Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #38
Update README #38
Changes from 28 commits
4aed185
fb18865
b26b60d
d86d3d8
e85cbec
ad97888
5701196
c25532f
85b0d12
2ff98ba
35e97f7
38a1931
f6b843f
a2eec1a
45b49a6
4540a02
1fc262e
7b24180
9d70f53
61f9769
d60fd20
629e293
88c3901
a0be65b
7e1e58d
aba3d08
6c526db
e347278
22aa9f3
6ec0ab8
7470286
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm developer experience if someone doesn't have access to our apis repo -- Are they still able to contribute fixes? They just couldn't run the build-protos step, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that's the case, yeah. We should make that explicit in the documentation (I'm working on the same thing in Go atm for the
CONTRIBUTING.md
).My understanding is since we check in the generated code, and there's no dependency on the submodule for general development, this shouldn't hinder folks who are looking to submit changes publicly.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.