Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split integration test file #42

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

emily-emily
Copy link
Contributor

Problem

Currently all of our integration tests are included in a single file, making it hard to navigate and read.

Solution

This PR splits the integration tests into multiple files: common.rs for common helper code (eg. generate index name), and two files for control plane and data plane integration tests.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

All existing test cases pass

@emily-emily emily-emily self-assigned this Jul 25, 2024
@emily-emily emily-emily marked this pull request as ready for review July 25, 2024 14:53
Copy link
Contributor

@ssmith-pc ssmith-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review in detail, but I trust that you know what you're doing here

@emily-emily emily-emily merged commit 05ed9ff into main Jul 26, 2024
1 check passed
@emily-emily emily-emily deleted the emily/split-integration-tests branch July 26, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants