Restore environment variables to original state after tests #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current tests manipulate environment variables and do not restore the original values after execution. This can cause problems for subsequent tests, eg. when the env var overrides something important or is intentionally set to an invalid value for the test.
Solution
This PR introduces the
temp_env
crate, which restores original environment variable values after the given scope. It uses a mutex to lock the variables so they cannot be concurrently accessed during the tests.Test cases were also updated to to use a Result return type.
Type of Change
Test Plan
All tests pass with the updated environment variable code.