Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsdb: update vm to v1.76.1; expose more params #213

Merged
merged 2 commits into from
Nov 30, 2023
Merged

tsdb: update vm to v1.76.1; expose more params #213

merged 2 commits into from
Nov 30, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Nov 30, 2023

What problem does this PR solve?

Issue Number: close #212

What is changed and how it works?

  • Expose -search.maxUniqueTimeseries to users. This is done by adding a new item to the configuration file.
  • Also add -retentionPeriod to the configuration file. (Note: cmdline arg take precedence over configuration file.)
  • Upgrade vm to v1.76.1 for -search.maxUniqueTimeseries to take effect.

Example:

# config.toml
# ...

[tsdb]
# Data with timestamps outside the retentionPeriod is automatically deleted
# The following optional suffixes are supported: h (hour), d (day), w (week), y (year).
# If suffix isn't set, then the duration is counted in months.
retention-period = "1"
# `search-max-unique-timeseries` limits the number of unique time series a single query can find and process.
# VictoriaMetrics(tsdb) keeps in memory some metainformation about the time series located by each query
# and spends some CPU time for processing the found time series. This means that the maximum memory usage
# and CPU usage a single query can use is proportional to `search-max-unique-timeseries`.
search-max-unique-timeseries = 300000

Signed-off-by: mornyx <mornyx.z@gmail.com>
@ti-chi-bot ti-chi-bot bot added the size/XXL label Nov 30, 2023
Signed-off-by: mornyx <mornyx.z@gmail.com>
@mornyx mornyx added lgtm and removed lgtm labels Nov 30, 2023
Copy link

@zhangpeijin-milo zhangpeijin-milo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 30, 2023
Copy link

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 06:55:12.902504664 +0000 UTC m=+1078541.567730860: ☑️ agreed by zhangpeijin-milo.

Copy link

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangpeijin-milo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 30, 2023
@mornyx
Copy link
Collaborator Author

mornyx commented Nov 30, 2023

/merge

Copy link

ti-chi-bot bot commented Nov 30, 2023

@mornyx: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mornyx mornyx merged commit f223e14 into main Nov 30, 2023
1 check passed
@mornyx mornyx deleted the mornyx/vm branch November 30, 2023 06:56
@mornyx
Copy link
Collaborator Author

mornyx commented Nov 30, 2023

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-6.5: #214.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/ng-monitoring that referenced this pull request Nov 30, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@pingcap pingcap deleted a comment from ti-chi-bot Nov 30, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Nov 30, 2023
@mornyx
Copy link
Collaborator Author

mornyx commented Dec 5, 2023

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-7.1: #215.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/ng-monitoring that referenced this pull request Dec 5, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2023
@mornyx
Copy link
Collaborator Author

mornyx commented Jul 25, 2024

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-7.5: #253.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/ng-monitoring that referenced this pull request Jul 25, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top SQL: The number of matching unique timeseries exceeds 300000
3 participants