Eliminate warnings. #223
Merged
Eliminate warnings. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqarryzada
commented
May 17, 2024
| { | ||
| throw new IllegalArgumentException( | ||
| "Attempted to skip a negative number of characters."); | ||
| } |
There was a problem hiding this comment.
I needed to ensure that the input value was not a very large negative number. The parent class throws an IllegalArgumentException for any negative value, so it made sense to include that here too.
Updated some SDK code to avoid warning messages from code scanning tools. This includes a change to the StringReader#skip method, which now explicitly checks for negative values. JiraIssue: DS-48860
kqarryzada
force-pushed
the
DS-48860-update-warnings
branch
from
e6a6088
to
d5c2e1f
Compare
|
I've left details about testing this change on Jira. |
dougbulkley
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated some SDK code to avoid warning messages from code scanning tools. This includes a change to the StringReader#skip method, which now explicitly checks for negative values.
JiraIssue: DS-48860