Support ADD patch ops targeting existing values #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyhhuang
reviewed
Sep 6, 2024
scim2-sdk-common/src/main/java/com/unboundid/scim2/common/messages/PatchOperation.java
Outdated
Show resolved
Hide resolved
scim2-sdk-common/src/main/java/com/unboundid/scim2/common/messages/PatchOperation.java
Outdated
Show resolved
Hide resolved
scim2-sdk-common/src/main/java/com/unboundid/scim2/common/messages/PatchOperation.java
Outdated
Show resolved
Hide resolved
scim2-sdk-common/src/main/java/com/unboundid/scim2/common/messages/PatchOperation.java
Outdated
Show resolved
Hide resolved
dougbulkley
approved these changes
Sep 19, 2024
kqarryzada
force-pushed
the
DS-49194-add-with-value-filter-should-target-existing-data
branch
from
8069300
to
a33e2a1
Compare
Added a release note that indicates that the Jackson dependency was upgraded.
In the 3.0.0 release, we implemented support for ADD patch operations with a value filter. The SDK would always append a new value to the array, since it is technically an "add". However, this does not play well with SCIM provisioners that send multiple individual updates, since these intend to target the same value within a multi-valued attribute, such as a user's work email. The intention is to add a new value to the field that matches the path filter (e.g., "type eq \"work\""). This commit adds support for this behavior. The new behavior is available via an opt-in setting in a static boolean variable, PatchOperation.APPEND_NEW_PATCH_VALUES_PROPERTY. To opt into this setting, set the value of this variable to false. As a result of this change, the version of the SCIM SDK has been updated to 3.2.0-SNAPSHOT. Reviewer: vyhhuang Reviewer: dougbulkley JiraIssue: DS-49194
kqarryzada
force-pushed
the
DS-49194-add-with-value-filter-should-target-existing-data
branch
from
a33e2a1
to
6f74c28
Compare
vyhhuang
approved these changes
Sep 19, 2024
kqarryzada
deleted the
DS-49194-add-with-value-filter-should-target-existing-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 3.0.0 release, we implemented support for ADD patch operations
with a value filter. The SDK would always append a new value to the
array, since it is technically an "add". However, this does not play
well with SCIM provisioners that send multiple individual updates,
since these intend to target the same value within a multi-valued
attribute, such as a user's work email. The intention is to add a new
value to the field that matches the path filter (e.g.,
"type eq "work"").
The new behavior is available via an opt-in setting in a static boolean
variable, PatchOperation.APPEND_NEW_PATCH_VALUES_PROPERTY. To opt into
this setting, set the value of this variable to false.
As a result of this change, the version of the SCIM SDK has been updated
to 3.2.0-SNAPSHOT.
Reviewer: vyhhuang
Reviewer: dougbulkley
JiraIssue: DS-49194
Resolves #213