-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support clean DaVinci environments #250
Merged
patrickcping
merged 70 commits into
main
from
support-clean-davinci-environment-creation-202312
Mar 27, 2024
Merged
Support clean DaVinci environments #250
patrickcping
merged 70 commits into
main
from
support-clean-davinci-environment-creation-202312
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 8, 2024
Closed
|
TestingCommandTF_ACC=1 go test -v -timeout 3000s -run ^ github.com/pingidentity/terraform-provider-davinci/internal/service/davinci ResultsExpand Results=== RUN TestAccDataSourceApplication_DefinedApplication_ByID_Clean
=== PAUSE TestAccDataSourceApplication_DefinedApplication_ByID_Clean
=== RUN TestAccDataSourceApplication_DefinedApplication_ByID_WithBootstrap
=== PAUSE TestAccDataSourceApplication_DefinedApplication_ByID_WithBootstrap
=== RUN TestAccDataSourceApplication_BootstrapApplication_ByID_WithBootstrap
=== PAUSE TestAccDataSourceApplication_BootstrapApplication_ByID_WithBootstrap
=== RUN TestAccDataSourceApplication_NotFound
=== PAUSE TestAccDataSourceApplication_NotFound
=== RUN TestAccDataSourceApplications_AllApplications_Clean
=== PAUSE TestAccDataSourceApplications_AllApplications_Clean
=== RUN TestAccDataSourceApplications_AllApplications_WithBootstrap
=== PAUSE TestAccDataSourceApplications_AllApplications_WithBootstrap
=== RUN TestAccDataSourceConnection_DefinedConnection_ByID_Clean
=== PAUSE TestAccDataSourceConnection_DefinedConnection_ByID_Clean
=== RUN TestAccDataSourceConnection_DefinedConnection_ByID_WithBootstrap
=== PAUSE TestAccDataSourceConnection_DefinedConnection_ByID_WithBootstrap
=== RUN TestAccDataSourceConnection_DefinedConnection_ByName_Clean
=== PAUSE TestAccDataSourceConnection_DefinedConnection_ByName_Clean
=== RUN TestAccDataSourceConnection_DefinedConnection_ByName_WithBootstrap
=== PAUSE TestAccDataSourceConnection_DefinedConnection_ByName_WithBootstrap
=== RUN TestAccDataSourceConnection_BootstrapConnection_ByID_Clean
=== PAUSE TestAccDataSourceConnection_BootstrapConnection_ByID_Clean
=== RUN TestAccDataSourceConnection_BootstrapConnection_ByID_WithBootstrap
=== PAUSE TestAccDataSourceConnection_BootstrapConnection_ByID_WithBootstrap
=== RUN TestAccDataSourceConnection_BootstrapConnection_ByName_Clean
=== PAUSE TestAccDataSourceConnection_BootstrapConnection_ByName_Clean
=== RUN TestAccDataSourceConnection_BootstrapConnection_ByName_WithBootstrap
=== PAUSE TestAccDataSourceConnection_BootstrapConnection_ByName_WithBootstrap
=== RUN TestAccDataSourceConnection_NotFound
=== PAUSE TestAccDataSourceConnection_NotFound
=== RUN TestAccDataSourceConnections_AllConnections_Clean
=== PAUSE TestAccDataSourceConnections_AllConnections_Clean
=== RUN TestAccDataSourceConnections_AllConnections_WithBootstrap
=== PAUSE TestAccDataSourceConnections_AllConnections_WithBootstrap
=== RUN TestAccDataSourceConnections_FilteredConnections_Clean
=== PAUSE TestAccDataSourceConnections_FilteredConnections_Clean
=== RUN TestAccDataSourceConnections_FilteredConnections_WithBootstrap
=== PAUSE TestAccDataSourceConnections_FilteredConnections_WithBootstrap
=== RUN TestAccResourceApplicationFlowPolicy_RemovalDrift
=== PAUSE TestAccResourceApplicationFlowPolicy_RemovalDrift
=== RUN TestAccResourceApplicationFlowPolicy_Full
=== PAUSE TestAccResourceApplicationFlowPolicy_Full
=== RUN TestAccResourceApplicationFlowPolicy_WithPolicyFlow_Full
=== PAUSE TestAccResourceApplicationFlowPolicy_WithPolicyFlow_Full
=== RUN TestAccResourceApplication_RemovalDrift
=== PAUSE TestAccResourceApplication_RemovalDrift
=== RUN TestAccResourceApplication_Full_Clean
=== PAUSE TestAccResourceApplication_Full_Clean
=== RUN TestAccResourceApplication_Full_WithBootstrap
=== PAUSE TestAccResourceApplication_Full_WithBootstrap
=== RUN TestAccResourceApplication_WithOAuth_Full
=== PAUSE TestAccResourceApplication_WithOAuth_Full
=== RUN TestAccResourceApplication_BadParameters
=== PAUSE TestAccResourceApplication_BadParameters
=== RUN TestAccResourceConnection_RemovalDrift
=== PAUSE TestAccResourceConnection_RemovalDrift
=== RUN TestAccResourceConnection_Full_Clean
=== PAUSE TestAccResourceConnection_Full_Clean
=== RUN TestAccResourceConnection_Full_WithBootstrap
=== PAUSE TestAccResourceConnection_Full_WithBootstrap
=== RUN TestAccResourceConnection_Properties
=== PAUSE TestAccResourceConnection_Properties
=== RUN TestAccResourceConnection_BadParameters
=== PAUSE TestAccResourceConnection_BadParameters
=== RUN TestAccResourceFlow_RemovalDrift
=== PAUSE TestAccResourceFlow_RemovalDrift
=== RUN TestAccResourceFlow_Basic_Clean
=== PAUSE TestAccResourceFlow_Basic_Clean
=== RUN TestAccResourceFlow_Basic_WithBootstrap
=== PAUSE TestAccResourceFlow_Basic_WithBootstrap
=== RUN TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_Clean
=== PAUSE TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_Clean
=== RUN TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_WithBootstrap
=== PAUSE TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_WithBootstrap
=== RUN TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_Clean
=== PAUSE TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_Clean
=== RUN TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_WithBootstrap
=== PAUSE TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_WithBootstrap
=== RUN TestAccResourceFlow_ComputeDifferences_ModifySettings
=== PAUSE TestAccResourceFlow_ComputeDifferences_ModifySettings
=== RUN TestAccResourceFlow_ComputeDifferences_CompanyId
=== PAUSE TestAccResourceFlow_ComputeDifferences_CompanyId
=== RUN TestAccResourceFlow_ComputeDifferences_Version
=== PAUSE TestAccResourceFlow_ComputeDifferences_Version
=== RUN TestAccResourceFlow_ComputeDifferences_Description
=== PAUSE TestAccResourceFlow_ComputeDifferences_Description
=== RUN TestAccResourceFlow_ComputeDifferences_AdditionalProperties
=== PAUSE TestAccResourceFlow_ComputeDifferences_AdditionalProperties
=== RUN TestAccResourceFlow_ComputeDifferences_NewNode
=== PAUSE TestAccResourceFlow_ComputeDifferences_NewNode
=== RUN TestAccResourceFlow_BrokenFlow
=== PAUSE TestAccResourceFlow_BrokenFlow
=== RUN TestAccResourceFlow_BadParameters
=== PAUSE TestAccResourceFlow_BadParameters
=== RUN TestAccResourceVariable_RemovalDrift
=== PAUSE TestAccResourceVariable_RemovalDrift
=== RUN TestAccResourceVariable_Full_CompanyContext_Clean
=== PAUSE TestAccResourceVariable_Full_CompanyContext_Clean
=== RUN TestAccResourceVariable_Full_CompanyContext_WithBootstrap
=== PAUSE TestAccResourceVariable_Full_CompanyContext_WithBootstrap
=== RUN TestAccResourceVariable_Full_FlowInstanceContext_Clean
=== PAUSE TestAccResourceVariable_Full_FlowInstanceContext_Clean
=== RUN TestAccResourceVariable_Full_FlowInstanceContext_WithBootstrap
=== PAUSE TestAccResourceVariable_Full_FlowInstanceContext_WithBootstrap
=== RUN TestAccResourceVariable_Full_UserContext_Clean
=== PAUSE TestAccResourceVariable_Full_UserContext_Clean
=== RUN TestAccResourceVariable_Full_UserContext_WithBootstrap
=== PAUSE TestAccResourceVariable_Full_UserContext_WithBootstrap
=== RUN TestAccResourceVariable_ChangeDataType
=== PAUSE TestAccResourceVariable_ChangeDataType
=== RUN TestAccResourceVariable_BadParameters
=== PAUSE TestAccResourceVariable_BadParameters
=== CONT TestAccDataSourceApplication_DefinedApplication_ByID_Clean
=== CONT TestAccResourceVariable_ChangeDataType
=== CONT TestAccResourceConnection_RemovalDrift
=== CONT TestAccResourceFlow_ComputeDifferences_Version
=== CONT TestAccDataSourceConnection_NotFound
=== CONT TestAccResourceApplicationFlowPolicy_WithPolicyFlow_Full
=== CONT TestAccDataSourceConnection_DefinedConnection_ByID_WithBootstrap
=== CONT TestAccDataSourceConnection_BootstrapConnection_ByName_WithBootstrap
=== CONT TestAccDataSourceConnection_BootstrapConnection_ByName_Clean
=== CONT TestAccDataSourceApplications_AllApplications_Clean
=== CONT TestAccDataSourceConnection_DefinedConnection_ByName_Clean
=== CONT TestAccResourceFlow_Basic_WithBootstrap
=== CONT TestAccDataSourceConnection_BootstrapConnection_ByID_WithBootstrap
=== CONT TestAccDataSourceConnection_BootstrapConnection_ByID_Clean
=== CONT TestAccDataSourceConnection_DefinedConnection_ByName_WithBootstrap
=== CONT TestAccDataSourceConnection_DefinedConnection_ByID_Clean
=== NAME TestAccResourceFlow_Basic_WithBootstrap
resource_flow_test.go:179: Skipping test with bootstrap config: https://github.com/pingidentity/terraform-provider-davinci/issues/266
--- SKIP: TestAccResourceFlow_Basic_WithBootstrap (0.02s)
=== CONT TestAccDataSourceApplications_AllApplications_WithBootstrap
=== NAME TestAccResourceConnection_RemovalDrift
resource_connection_test.go:32: Skipping step 3/4 due to SkipFunc
resource_connection_test.go:32: Skipping step 4/4 due to SkipFunc
--- PASS: TestAccDataSourceConnection_BootstrapConnection_ByName_Clean (152.13s)
=== CONT TestAccDataSourceConnections_FilteredConnections_WithBootstrap
--- PASS: TestAccDataSourceConnection_BootstrapConnection_ByID_Clean (152.49s)
=== CONT TestAccResourceApplicationFlowPolicy_Full
--- PASS: TestAccResourceConnection_RemovalDrift (156.52s)
=== CONT TestAccResourceApplicationFlowPolicy_RemovalDrift
--- PASS: TestAccDataSourceApplication_DefinedApplication_ByID_Clean (159.80s)
=== CONT TestAccResourceConnection_BadParameters
--- PASS: TestAccDataSourceConnection_NotFound (168.10s)
=== CONT TestAccResourceFlow_Basic_Clean
--- PASS: TestAccResourceVariable_ChangeDataType (192.66s)
=== CONT TestAccResourceFlow_RemovalDrift
--- PASS: TestAccResourceFlow_ComputeDifferences_Version (260.02s)
=== CONT TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_WithBootstrap
--- PASS: TestAccResourceConnection_BadParameters (104.17s)
=== CONT TestAccResourceFlow_ComputeDifferences_CompanyId
--- PASS: TestAccDataSourceConnection_BootstrapConnection_ByID_WithBootstrap (271.96s)
=== CONT TestAccDataSourceConnections_FilteredConnections_Clean
=== NAME TestAccResourceFlow_RemovalDrift
resource_flow_test.go:39: Skipping step 3/4 due to SkipFunc
resource_flow_test.go:39: Skipping step 4/4 due to SkipFunc
--- PASS: TestAccDataSourceConnection_BootstrapConnection_ByName_WithBootstrap (274.84s)
=== CONT TestAccResourceConnection_Full_WithBootstrap
--- PASS: TestAccDataSourceConnection_DefinedConnection_ByName_WithBootstrap (283.10s)
=== CONT TestAccResourceConnection_Properties
--- PASS: TestAccDataSourceConnection_DefinedConnection_ByID_Clean (289.65s)
=== CONT TestAccResourceFlow_ComputeDifferences_ModifySettings
--- PASS: TestAccDataSourceConnection_DefinedConnection_ByID_WithBootstrap (289.84s)
=== CONT TestAccResourceVariable_BadParameters
--- PASS: TestAccResourceFlow_RemovalDrift (99.82s)
=== CONT TestAccDataSourceConnections_AllConnections_Clean
=== NAME TestAccResourceConnection_Properties
resource_connection_test.go:233: Step 1/6 error: Error running apply: exit status 1
Error: Authorization failed!
with davinci_connection.eojanipsvb,
on terraform_plugin_test.tf line 42, in resource "davinci_connection" "eojanipsvb":
42: resource "davinci_connection" "eojanipsvb" {
--- FAIL: TestAccResourceConnection_Properties (198.87s)
=== CONT TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_WithBootstrap
resource_flow_test.go:322: Skipping test with bootstrap config: https://github.com/pingidentity/terraform-provider-davinci/issues/266
--- SKIP: TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_WithBootstrap (0.01s)
=== CONT TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_Clean
--- PASS: TestAccDataSourceConnection_DefinedConnection_ByName_Clean (494.78s)
=== CONT TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_Clean
--- PASS: TestAccResourceVariable_BadParameters (269.57s)
=== CONT TestAccDataSourceApplication_BootstrapApplication_ByID_WithBootstrap
=== NAME TestAccResourceApplicationFlowPolicy_RemovalDrift
resource_application_flow_policy_test.go:35: Skipping step 5/6 due to SkipFunc
resource_application_flow_policy_test.go:35: Skipping step 6/6 due to SkipFunc
--- PASS: TestAccDataSourceApplications_AllApplications_WithBootstrap (596.60s)
=== CONT TestAccDataSourceApplication_DefinedApplication_ByID_WithBootstrap
--- PASS: TestAccDataSourceApplications_AllApplications_Clean (596.99s)
=== CONT TestAccDataSourceApplication_NotFound
--- PASS: TestAccDataSourceConnections_FilteredConnections_WithBootstrap (445.18s)
=== CONT TestAccResourceConnection_Full_Clean
--- PASS: TestAccResourceApplicationFlowPolicy_RemovalDrift (446.63s)
=== CONT TestAccDataSourceConnections_AllConnections_WithBootstrap
--- PASS: TestAccDataSourceApplication_NotFound (28.40s)
=== CONT TestAccResourceVariable_Full_CompanyContext_Clean
--- PASS: TestAccDataSourceApplication_DefinedApplication_ByID_WithBootstrap (74.49s)
=== CONT TestAccResourceFlow_BrokenFlow
--- PASS: TestAccResourceFlow_ComputeDifferences_CompanyId (442.72s)
=== CONT TestAccResourceVariable_Full_UserContext_WithBootstrap
--- PASS: TestAccResourceFlow_ComputeDifferences_ModifySettings (466.50s)
=== CONT TestAccResourceFlow_BadParameters
--- PASS: TestAccResourceFlow_BrokenFlow (89.01s)
=== CONT TestAccResourceVariable_Full_UserContext_Clean
--- PASS: TestAccDataSourceConnections_FilteredConnections_Clean (496.93s)
=== CONT TestAccResourceVariable_Full_FlowInstanceContext_WithBootstrap
--- PASS: TestAccDataSourceConnections_AllConnections_Clean (477.90s)
=== CONT TestAccResourceVariable_RemovalDrift
=== NAME TestAccResourceVariable_Full_CompanyContext_Clean
resource_variable_test.go:120: Skipping step 6/8 due to SkipFunc
=== NAME TestAccResourceVariable_RemovalDrift
resource_variable_test.go:32: Skipping step 3/4 due to SkipFunc
resource_variable_test.go:32: Skipping step 4/4 due to SkipFunc
--- PASS: TestAccResourceVariable_RemovalDrift (67.44s)
=== CONT TestAccResourceVariable_Full_FlowInstanceContext_Clean
--- PASS: TestAccDataSourceApplication_BootstrapApplication_ByID_WithBootstrap (282.36s)
=== CONT TestAccResourceVariable_Full_CompanyContext_WithBootstrap
--- PASS: TestAccDataSourceConnections_AllConnections_WithBootstrap (243.92s)
=== CONT TestAccResourceFlow_ComputeDifferences_AdditionalProperties
--- PASS: TestAccResourceConnection_Full_WithBootstrap (574.30s)
=== CONT TestAccResourceFlow_ComputeDifferences_NewNode
--- PASS: TestAccResourceFlow_BadParameters (152.36s)
=== CONT TestAccResourceApplication_Full_WithBootstrap
=== NAME TestAccResourceVariable_Full_UserContext_WithBootstrap
resource_variable_test.go:322: Skipping step 6/8 due to SkipFunc
--- PASS: TestAccResourceVariable_Full_CompanyContext_Clean (291.19s)
=== CONT TestAccResourceApplication_BadParameters
=== NAME TestAccResourceVariable_Full_UserContext_Clean
resource_variable_test.go:322: Skipping step 6/8 due to SkipFunc
=== NAME TestAccResourceVariable_Full_FlowInstanceContext_WithBootstrap
resource_variable_test.go:221: Skipping step 6/8 due to SkipFunc
=== CONT TestAccResourceApplication_RemovalDrift
--- PASS: TestAccResourceConnection_Full_Clean (397.29s)
--- PASS: TestAccResourceVariable_Full_UserContext_WithBootstrap (288.25s)
=== CONT TestAccResourceApplication_WithOAuth_Full
--- PASS: TestAccResourceApplication_BadParameters (140.78s)
=== CONT TestAccResourceFlow_ComputeDifferences_Description
--- PASS: TestAccResourceFlow_Basic_Clean (890.37s)
=== CONT TestAccResourceApplication_Full_Clean
--- PASS: TestAccResourceVariable_Full_UserContext_Clean (304.61s)
=== NAME TestAccResourceVariable_Full_CompanyContext_WithBootstrap
resource_variable_test.go:120: Skipping step 6/8 due to SkipFunc
--- PASS: TestAccResourceApplicationFlowPolicy_Full (914.03s)
=== NAME TestAccResourceVariable_Full_FlowInstanceContext_Clean
resource_variable_test.go:221: Skipping step 6/8 due to SkipFunc
--- PASS: TestAccResourceVariable_Full_FlowInstanceContext_WithBootstrap (300.56s)
=== NAME TestAccResourceApplication_RemovalDrift
resource_application_test.go:32: Skipping step 3/4 due to SkipFunc
resource_application_test.go:32: Skipping step 4/4 due to SkipFunc
--- PASS: TestAccResourceApplication_RemovalDrift (86.24s)
=== NAME TestAccResourceApplication_Full_Clean
resource_application_test.go:135: Step 1/8 error: Error running apply: exit status 1
Error: Authorization failed!
with davinci_application.elnfyjeqtz,
on terraform_plugin_test.tf line 42, in resource "davinci_application" "elnfyjeqtz":
42: resource "davinci_application" "elnfyjeqtz" {
--- FAIL: TestAccResourceApplication_Full_Clean (158.46s)
--- PASS: TestAccResourceFlow_ComputeDifferences_AdditionalProperties (378.52s)
--- PASS: TestAccResourceVariable_Full_CompanyContext_WithBootstrap (398.94s)
--- PASS: TestAccResourceFlow_ComputeDifferences_NewNode (391.85s)
--- PASS: TestAccResourceVariable_Full_FlowInstanceContext_Clean (407.78s)
--- PASS: TestAccResourceApplicationFlowPolicy_WithPolicyFlow_Full (1256.85s)
--- PASS: TestAccResourceFlow_ConnectionSubflowLinks_WithMappingIDs_Clean (799.96s)
--- PASS: TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_Clean (787.54s)
--- PASS: TestAccResourceApplication_Full_WithBootstrap (381.19s)
--- PASS: TestAccResourceFlow_ComputeDifferences_Description (232.80s)
=== NAME TestAccResourceApplication_WithOAuth_Full
resource_application_test.go:279: Step 9/12 error: Error running apply: exit status 1
Error: Authorization failed!
with davinci_application.rjceeymekr,
on terraform_plugin_test.tf line 42, in resource "davinci_application" "rjceeymekr":
42: resource "davinci_application" "rjceeymekr" {
--- FAIL: TestAccResourceApplication_WithOAuth_Full (479.66s)
--- PASS: TestAccResourceFlow_ConnectionSubflowLinks_WithoutMappingIDs_WithBootstrap (1506.72s)
FAIL
FAIL github.com/pingidentity/terraform-provider-davinci/internal/service/davinci 1767.845s ( |
|
samir-gandhi
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added single comment in pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the API (and the PingOne provider) supports creation of a clean DaVinci environment, this change is to align the provider to remove HCL writing complexity, update tests for empty environments and include regression tests for bootstrapped environments.