diff --git a/CHANGELOG.md b/CHANGELOG.md index f8ded2729..ec11b8372 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # v0.8.0 (Unreleased) ### BUG FIXES * `pingfederate_oauth_auth_server_settings` resource, removed unnecessary requirement for `bypass_activation_code_confirmation`, `default_scope_description`, `device_polling_interval`, `pending_authorization_timeout`, `registered_authorization_path` properties([#216](https://github.com/pingidentity/terraform-provider-pingfederate/pull/216)) -* `pingfederate_oauth_client` resource, Provider produced inconsistent result after apply error when applying empty `extended_parameters` map value, require `values` property within to match product behavior ([#204](https://github.com/pingidentity/terraform-provider-pingfederate/pull/204))([#214](https://github.com/pingidentity/terraform-provider-pingfederate/pull/214)) +* `pingfederate_oauth_client` resource, "Provider produced inconsistent result after apply" error when applying empty `extended_parameters` map value, require `values` property within to match product behavior. Fixed `logo_url` "Invalid URL Format" when empty string supplied. ([#204](https://github.com/pingidentity/terraform-provider-pingfederate/pull/204))([#214](https://github.com/pingidentity/terraform-provider-pingfederate/pull/214))([#217](https://github.com/pingidentity/terraform-provider-pingfederate/pull/217)) # v0.7.1 February 29th, 2024 ### BUG FIXES diff --git a/internal/acctest/config/oauth/client/oauth_client_test.go b/internal/acctest/config/oauth/client/oauth_client_test.go index 403ac00ce..2db10774a 100644 --- a/internal/acctest/config/oauth/client/oauth_client_test.go +++ b/internal/acctest/config/oauth/client/oauth_client_test.go @@ -77,6 +77,7 @@ func TestAccOauthClient(t *testing.T) { grantTypes: []string{"DEVICE_CODE"}, includeOptionalAttributes: false, includeExtendedParameters: false, + logoUrl: pointers.String(""), } updatedResourceModel := oauthClientResourceModel{ diff --git a/internal/resource/configvalidators/url_validator.go b/internal/resource/configvalidators/url_validator.go index 1d8cdcfd3..f7ca13eaf 100644 --- a/internal/resource/configvalidators/url_validator.go +++ b/internal/resource/configvalidators/url_validator.go @@ -28,7 +28,7 @@ func (v urlValidator) MarkdownDescription(ctx context.Context) string { func (v urlValidator) ValidateString(ctx context.Context, req validator.StringRequest, resp *validator.StringResponse) { // If the value is unknown or null, there is nothing to validate. - if req.ConfigValue.IsUnknown() || req.ConfigValue.IsNull() { + if req.ConfigValue.IsUnknown() || req.ConfigValue.IsNull() || req.ConfigValue.ValueString() == "" { return }