Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtering support for pingone_verify_policies data source. #577

Open
mjspi opened this issue Sep 28, 2023 · 0 comments
Open

Implement filtering support for pingone_verify_policies data source. #577

mjspi opened this issue Sep 28, 2023 · 0 comments
Labels
service/verify PingOne Verify size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) status/needs-triage The issue/PR needs initial triage type/enhancement New feature or request
Milestone

Comments

@mjspi
Copy link
Contributor

mjspi commented Sep 28, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The pingone_verify_policies data source does not provide an option to include a search filter, whereas the underlying API supports a request to include a SCIM filter expression for the name property to retrieve a subset of all policies.

The enhancement will introduce SCIM filter options for the name attribute. Requirements evaluation will determine if the inclusion of a data filter option, in addition to the SCIM filter option, would be useful.

New or Affected Resource(s)

  • pingone_verify_policies

Potential Terraform Configuration

# Copy-paste your PingOne related Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

# Remember to replace any account/customer sensitive information in the configuration before submitting the issue
data "pingone_verify_policies" "scim_filter_example" {
  environment_id = var.environment_id

  scim_filter         = "(name sw \"Department\")"
}

References

@mjspi mjspi added type/enhancement New feature or request service/verify PingOne Verify size/small Small change (e.g. adding a small number of parameters to an existing resource/datasource schema) labels Sep 28, 2023
@mjspi mjspi added this to the v0.22.0 milestone Sep 28, 2023
@mjspi mjspi self-assigned this Sep 28, 2023
@mjspi mjspi changed the title Implement filtering supporting for pingone_verify_policies data source. Implement filtering support for pingone_verify_policies data source. Sep 28, 2023
@patrickcping patrickcping modified the milestones: v0.22.0, v0.23.0 Oct 2, 2023
@mjspi mjspi added status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) and removed size/small Small change (e.g. adding a small number of parameters to an existing resource/datasource schema) labels Oct 11, 2023
@mjspi mjspi added status/needs-triage The issue/PR needs initial triage and removed status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK labels Oct 21, 2023
@mjspi mjspi removed their assignment Oct 24, 2023
@patrickcping patrickcping removed this from the v0.23.0 milestone Oct 25, 2023
@patrickcping patrickcping modified the milestones: v1.1.0, v1.2.0 Jul 8, 2024
@patrickcping patrickcping modified the milestones: v1.2.0, v1.3.0 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/verify PingOne Verify size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) status/needs-triage The issue/PR needs initial triage type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants