Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks should load on a page #96

Open
deas opened this issue Jan 12, 2020 · 0 comments
Open

Notebooks should load on a page #96

deas opened this issue Jan 12, 2020 · 0 comments

Comments

@deas
Copy link
Collaborator

deas commented Jan 12, 2020

The situation is pretty similar to that of Javascript playgrounds such codepen and the like.

The document (notebook in our case) may choose to require css- or js resources. The (notebook) application has to provide injection functionality. Injecting arbitrary can introduce all kinds of issues. Loading a page is the only safe way to get rid of whatever was introduce by injected resources. We should make sure all resources are loaded before we start evaluating code cells.

gorilla-notebook version

0.4.1-SNAPSHOT

Java version

n/a

Operating system

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant