Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (fixed) #131

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

10xLaCroixDrinker
Copy link
Contributor

Fixes the issues in #105

Updating to tap@18 resolved the issue of tests failing when running via tap CLI. However, tap migrated its coverage collection to c8 which uses v8's built-in coverage tooling, and deleting entries from the require cache in the test suite broke the coverage reporting. So I added nyc for coverage collection. I enabled the use-spawn-wrap option in nyc because without it the tests in child processes broke due of how nyc affects stdio in child processes. This does mean though that the coverage from those tests is not counted now. Hence the added istanbul ignore statement in index.js.

dependency-check is deprecated, so I replaced it with knip. There was a reference to a non-existent npm run deps script so I added knip there, and I added scripts to allow standard to be run on its own.

I also updated the scripts that test individual versions of debug so they wouldnt modify the package.json or lockfile and gave them a cleanup script to restore the previously installed version of debug on completion.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@10xLaCroixDrinker
Copy link
Contributor Author

In order for this to go in the test matrix would have to change. tap 18 requires Node 16. Standard requires Node 12.22 and knip requires Node 16 as well, but those don't really need to be run on a whole matrix.

Is that something we can change?

@mcollina
Copy link
Member

We can 100% dump everything but v18 and v20.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ec18197) to head (ad7b1f6).
Report is 1 commits behind head on master.

❗ Current head ad7b1f6 differs from pull request most recent head aaca32e. Consider uploading reports for the commit aaca32e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #131      +/-   ##
===========================================
+ Coverage   98.00%   100.00%   +2.00%     
===========================================
  Files           2         2              
  Lines          50        48       -2     
===========================================
- Hits           49        48       -1     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners jsumners changed the base branch from master to next April 6, 2024 11:53
@OleksandrKucherenko
Copy link

Is it merged?

@mcollina mcollina merged commit e04fa49 into pinojs:next Oct 15, 2024
7 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the update-dependencies-fixed branch October 15, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants