Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #308 include req.readableAborted flag to defaultSuccessfulRequestMessageProvider #309

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

someden
Copy link
Contributor

@someden someden commented Nov 20, 2023

Closes #308

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@someden
Copy link
Contributor Author

someden commented Nov 29, 2023

@mcollina done

@mcollina
Copy link
Member

A test is failing on node v14

@someden
Copy link
Contributor Author

someden commented Dec 26, 2023

@mcollina, do you have some plans to drop node v14 support?

@mcollina
Copy link
Member

Of course, might actually be time to drop v14 and v16.

@mcollina
Copy link
Member

Could you remove them from CI? I will bump the major.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 8b2e812 into pinojs:master Dec 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message "request completed" when request not completed
2 participants