Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options and level optional for TransportTargetOptions #1769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KonradSwierczynski
Copy link

Hey,
I saw that TypeScript requires options and level, while it seems I don't really need to provide them.
I've changed types in pino.d.ts so I don't need to do @ts-ignore.
Please take a look

@mcollina
Copy link
Member

mcollina commented Aug 4, 2023

Would you mind adding a test for this type change in https://github.com/pinojs/pino/tree/master/test/types? We use tsd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants