Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent AST names using a list of atoms #425

Open
jparise opened this issue Sep 15, 2018 · 0 comments
Open

Represent AST names using a list of atoms #425

jparise opened this issue Sep 15, 2018 · 0 comments
Milestone
2.0

Comments

@jparise
Copy link
Collaborator

jparise commented Sep 15, 2018

@fishcakez in #409:

I think that we should change the data structure for names to a list of atoms. This prevents some edge cases and going atom <> string. Also in our case each part of the name is a separate term so it fits better into the thinking. I think this would also make it so we could always use fully qualified names.
@jparise jparise added this to the 2.0 milestone Sep 15, 2018
@jparise jparise mentioned this issue Sep 29, 2018
Merged
jparise added a commit that referenced this issue Oct 1, 2018
@jparise
Remove the atomify/1 conversion function (#434)
99b77cc 
This function existed to safely deal with `nil` values, but there's only
one case where this is needed: when a service doesn't "extend" another.

Instead, we now use `List.to_atom/1` directly and convert the 'extends'
value to an atom in the parser. This might be further revised if we
decide that names should be represented as a list of atoms instead of
dotted atom names (per #425).
@jparise jparise pinned this issue Dec 22, 2018
@jparise jparise unpinned this issue Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@jparise