fix: make sure the cmd-f still work on readonly docs (#1532)

pinterest · Jan 13, 2025 · f9595b9 · f9595b9
1 parent ac64e35
commit f9595b9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/querybook/webapp/components/QueryEditor/QueryEditor.tsx b/querybook/webapp/components/QueryEditor/QueryEditor.tsx
@@ -459,7 +459,9 @@ export const QueryEditor: React.FC<
                     maxHeight={height === 'auto' ? '50vh' : null}
                     extensions={extensions}
                     basicSetup={basicSetup}
-                    editable={!readOnly}
+                    // editable is working on the editor view. set as true to make it still respond to keymaps, e.g. search
+                    editable={true}
+                    // readonly is working on the editor state. when true, the editor content will not change anyway.
                     readOnly={readOnly}
                     autoFocus={false}
                     onChange={onChangeHandler}