Hierarchical modelling #1662
Replies: 8 comments
-
@MichaelClerx @martinjrobins @ben18785 @chonlei I am happy to implement this solution. I am just wondering what your thoughts on identifying the parameters are, because it can get complicated. Example: I hope the pattern is somewhat clear, but you probably see my point of potential confusion. And when the popualtion models start to have different numbers of parameters it becomes more complicated. In my repository I circumvented this by giving each parameter meaningful names, but pints doesn't support names at the moment. Any thoughts? |
Beta Was this translation helpful? Give feedback.
-
What are the actions you want to do where the names are used? |
Beta Was this translation helpful? Give feedback.
-
The names are not really used by anything. It's more for someone evaluating the hierarchical loglikelihood to understand which parameter index corresponds to which model parameter, if that makes sense? |
Beta Was this translation helpful? Give feedback.
-
hmmmm... you could have a dict mapping names to indices, I guess? |
Beta Was this translation helpful? Give feedback.
-
Can you point me towards the classes where you've solved this problem in Erlotinib ? (I kept thinking it was a german pun. So glad to find out it's a drug :D ) |
Beta Was this translation helpful? Give feedback.
-
Yes a dict or just a list of names? Hahah yes it's a drug 😂 And here is the HierarchicalLogLikelihood https://erlotinib.readthedocs.io/en/latest/log_pdfs.html#erlotinib.HierarchicalLogLikelihood |
Beta Was this translation helpful? Give feedback.
-
That looks quite similar to what we have for parameter names in plots! See also #1171 :D and the tickets linked therein |
Beta Was this translation helpful? Give feedback.
-
I've implemented this ProblemModellingController class to make my life a little easier, so I wouldn't have to keep track of it (here is a notebook, if you'd like to see it in action https://nbviewer.jupyter.org/github/DavAug/erlotinib/blob/main/analysis/treating_lung_cancer/control_group_analysis/tgi_koch_2009_reparametrised_model/population_inference.ipynb). But I guess that wouldn't necessarily be something for pints. |
Beta Was this translation helpful? Give feedback.
-
There are some issues that have discussed hierarchical modelling before #1231 #1232 #1134 . Here is one more attempt that I've implemented in my repository https://erlotinib.readthedocs.io/en/latest/index.html.
New features that are going to be implemented with this issue:
Beta Was this translation helpful? Give feedback.
All reactions