-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug in XNES covariance matrix update. #1517
Conversation
5d6efc3
to
432e5cc
Compare
Currently failing on issue fixed in #1518 so waiting for that to be merged |
To see the effect, run
on |
Before:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted, Michael!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 9577 9577
=========================================
Hits 9577 9577 ☔ View full report in Codecov by Sentry. |
Fixed bug discovered when writing method merge test for xnes. Improves performance hugely on 2d rosenbrock