-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rt Notebook example - corrected #1523
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 9577 9577
=========================================
Hits 9577 9577 ☔ View full report in Codecov by Sentry. |
Can you give a bit of background about this example? What's the reason for including it (from a PINTS point of view: which features does it highlight)? In its current form I don't think it belong in the "toy" section of examples, as those all showcase a toy model included in the PINTS module. If you did want to make this into a PINTS toy problem, we would have to think about how (or whether) to include the CSV data, as we would have to then package this data as part of the |
It's meant to be an additional example for the paper, and to showcase how someone can try and define their own logPDF objects rather than resorting to singleOutput problems. I did struggle to find a good place to include it, to be honest. |
I suppose it could always go under "Miscellaneous", or it could go in a separate repo? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@ben18785 want to comment on the science of this? Or shall we just merge it in? |
OK, in it goes! |
No description provided.