Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs written to stdout when accessing stats on a closed connection peer connection #2768

Open
danjenkins opened this issue May 14, 2024 · 0 comments

Comments

@danjenkins
Copy link

Your environment.

  • Version: v4.0.0-beta.19
  • Browser: N/A

What did you do?

When accessing the Stats using GetStats() on a closed peer connection, logs get written out to stdout.

What did you expect?

Only a returned error should happen

What happened?

ice ERROR: 2024/05/14 09:31:01 Failed to get candidate pairs stats: the agent is closed
ice ERROR: 2024/05/14 09:31:01 Failed to get candidate pair stats: the agent is closed
ice ERROR: 2024/05/14 09:31:01 Failed to get candidate pair stats: the agent is closed

I guess theres another error here... I should still be able to get the candidate pair stats even when ice agent is closed - getting stats/data from a closed connection shouldn't error. I'm assuming the W3C spec allows for this - it should.

Guessing this error is actually in pion/ice but GetStats is the API I'm calling so I'm reporting it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant