Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit internal consistency of data structures that can start and stop #2868

Open
edaniels opened this issue Aug 13, 2024 · 0 comments
Open
Labels
bug Something isn't working difficulty:hard

Comments

@edaniels
Copy link
Member

It appears there are several cases such as if a peer connection shuts down before it is fully stable or is in the process of renegotiating, that closing it and any of its child structures can result in inconsistent state. This inconsistent state can lead to goroutine leaks but more importantly prevents any kind of reuse of the structures if that were to be desired.

The inconsistency is usually due to a combination of critical sections around a state machine. Given how intricate the interactions of each webrtc component is which can cause its own host of issues if one doesn't do operations to spec, this feels important to audit.

@Sean-Der Sean-Der added bug Something isn't working difficulty:hard labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working difficulty:hard
Development

No branches or pull requests

2 participants