Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetReadDeadline causes nil pointer dereference #2889

Open
thanhpk opened this issue Aug 25, 2024 · 1 comment
Open

SetReadDeadline causes nil pointer dereference #2889

thanhpk opened this issue Aug 25, 2024 · 1 comment
Labels
bug Something isn't working difficulty:moderate

Comments

@thanhpk
Copy link

thanhpk commented Aug 25, 2024

Your environment.

  • Version: v4.0.0-beta.29
  • Browser: include version
  • Stacktrace
/vendor/github.com/pion/webrtc/v4/srtp_writer_future.go:108
/vendor/github.com/pion/webrtc/v4/rtpsender.go:435

What did you do?

Call rtpSender.SetReadDeadline(t)

What did you expect?

Don't panic

What happened?

Panic

This line causes the panic
https://github.com/pion/webrtc/blob/master/srtp_writer_future.go#L108

I dont familiar with the project source code, but shouldn't you must call Store before call Load ?

@Sean-Der
Copy link
Member

Sean-Der commented Oct 7, 2024

Hi @thanhpk

How can I reproduce this? We have some simple tests, but I wasn't able to make it happen again.

@Sean-Der Sean-Der added bug Something isn't working difficulty:moderate labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working difficulty:moderate
Development

No branches or pull requests

2 participants