Styling polish #16
Merged
Styling polish #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change window icon from boilerplate placeholder to PiE logo.
Change window title to `Dawn ${versionString}`.
Use background color of info cards in topbar to indicate "good" ping and battery voltage. Tweak coloring of connection config button in topbar.
Change font in ConfirmModal. Make confirm button span width of modal. Who knows if this actually looks nicer.
Add backdrop blur to the keyboard control editor overlay. Add border to bottom of editor toolbar and file status. Pad file status so it looks aligned with the file name (curse you, fonts with different baselines!)
Change 'upload' -> 'transmit' since the code path is also used for downloading code. Remove debugging message.
Prevent images from being dragged. Add HelpModal with placeholder content. Make icons for ConnectionConfigButton. Extract ConnectionConfigButton to TopbarButton, then add another one that opens the HelpModal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taskbar icon still not changed for some reason.
Scrollbars now moved to inside each device card, and long device ids are truncated with ellipses (but can still be selected and copied in their entirety because of user-select: all).
Make up "good" and "bad" ranges for latency and battery voltage and change label color based on this.
Continuation of my private war on scrollbars
Different? Yes. Better? Who knows.