fix(un-jsx): disable preact's h pragma to avoid conflicting with no…

…rmal minified code #113
pionxzh · Feb 16, 2024 · a97c8ea · a97c8ea
1 parent 55e2938
commit a97c8ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/unminify/src/transformations/__tests__/un-jsx.spec.ts b/packages/unminify/src/transformations/__tests__/un-jsx.spec.ts
@@ -392,7 +392,7 @@ function Foo() {}
 
 inlineTest('jsx with xml namespace',
   `
-h("f:image", {
+jsx("f:image", {
   "n:attr": true
 });
 `,

diff --git a/packages/unminify/src/transformations/un-jsx.ts b/packages/unminify/src/transformations/un-jsx.ts
@@ -35,7 +35,9 @@ const DEFAULT_PRAGMA_CANDIDATES = [
     '_jsxs', // `import { jsxs as _jsxs } from 'react/jsx-runtime'`
     'jsxDEV', // runtime = "automatic" (`jsxRuntime.jsxDEV`) (dev only)
     'jsxsDEV', // runtime = "automatic" (`jsxRuntime.jsxsDEV`) (dev only)
-    'h', // Preact
+    // FIXME: disabled as it will conflict with minified code
+    // bring this back when we have a way to tell if the caller is `preact`
+    // 'h', // Preact
 ]
 
 const DEFAULT_PRAGMA_FRAG_CANDIDATES = [