Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support --perf-output in CLI #125

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

AhmadFaraz-crypto
Copy link
Contributor

@AhmadFaraz-crypto AhmadFaraz-crypto commented Apr 18, 2024

Closes #102

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wakaru ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 10:51am

packages/cli/src/cli.ts Outdated Show resolved Hide resolved
packages/cli/src/cli.ts Outdated Show resolved Hide resolved
@AhmadFaraz-crypto AhmadFaraz-crypto changed the title Added feat Support --perf-output in CLI Added Support --perf-output in CLI Apr 18, 2024
@pionxzh
Copy link
Owner

pionxzh commented Apr 18, 2024

LGTM! Thanks

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (c681550) to head (3822602).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files         100      100           
  Lines       12308    12308           
  Branches     1632     1632           
=======================================
  Hits        10995    10995           
  Misses       1259     1259           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pionxzh pionxzh merged commit ba0d7bc into pionxzh:main Apr 18, 2024
5 checks passed
@AhmadFaraz-crypto
Copy link
Contributor Author

LGTM! Thanks

Thanks 🙂! Let me know if there is anything else to contribute. I will be happy to help you.

@pionxzh
Copy link
Owner

pionxzh commented Apr 19, 2024

I think #82 and #116 would be easier to work on. But this two requests still have some uncertain part that might need further discussion. You can put some of your opinion and maybe implement part of them.

@AhmadFaraz-crypto
Copy link
Contributor Author

AhmadFaraz-crypto commented Apr 21, 2024

Sure, I will look into these issues.

@pionxzh
Copy link
Owner

pionxzh commented Apr 23, 2024

I have released CLI v0.0.10 with these changes.

@AhmadFaraz-crypto
Copy link
Contributor Author

Thanks for letting me know. I will check this version.

@AhmadFaraz-crypto
Copy link
Contributor Author

I will look into another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --perf-output in CLI
2 participants