Incorrect tab position

[DreamC]

Since I installed TST a few months ago I noticed some strange behavior with opened tabs. TST is set to open new child tabs next to recent tab (imitate Firefox behavior). Sometimes new tabs keep on creating after some sort of "old recent" tab even if focus them. Also focusing a tab while it is still loading does nothing - new child tab will be opened after recent tab instead of current.
I tried a fresh profile, but the problem is still there.
Is this the intended behavior or not? And should it be different from the "Firefox controls opened tabs"?

Video that will help to visualize it: https://youtu.be/bm_Aaz3N2nk

[irvinm]

I just created a new instance with no changes and installed TST and left it at defaults.

The tabs settings defaulted to:

When I tried your scenario, I created a tab and then from that tab opened links from that page as children and each of those new children were always created after the last child that was created. I then clicked on a few of the children and went to the partent and created more children tabs and again each tab (different that what you were seeing) were still created at the bottom of the tree. (FF 104.0.1, Win10, TST 3.8.26)

2022-09-01_16-24-00.mp4

[piroor]

Hmm, it may be triggered due to failure of updating lastRelatedTab around the code:

treestyletab/webextensions/background/successor-tab.js

Lines 184 to 220 in d6c455b

	Tab.onCreating.addListener((tab, info = {}) => {
	if (!info.activeTab)
	return;
	const shouldControlSuccesor = (
	configs.successorTabControlLevel != Constants.kSUCCESSOR_TAB_CONTROL_NEVER &&
	configs.simulateSelectOwnerOnClose
	);
	if (shouldControlSuccesor) {
	// don't use await here, to prevent that other onCreating handlers are treated async.
	tryClearOwnerSuccessor(info.activeTab).then(() => {
	const ownerTabId = tab.openerTabId || tab.active ? info.activeTab.id : null
	if (!ownerTabId)
	return;
	log(`${dumpTab(tab)} is prepared for "selectOwnerOnClose" behavior (successor=${ownerTabId})`);
	setSuccessor(tab.id, ownerTabId);
	tab.$TST.lastSuccessorTabId = ownerTabId;
	tab.$TST.lastSuccessorTabIdByOwner = true;
	if (!tab.openerTabId)
	return;
	const opener = Tab.get(tab.openerTabId);
	const lastRelatedTab = opener && opener.$TST.lastRelatedTab;
	if (lastRelatedTab)
	tryClearOwnerSuccessor(lastRelatedTab);
	opener.$TST.lastRelatedTab = tab;
	});
	}
	else {
	const opener = Tab.get(tab.openerTabId);
	if (opener)
	opener.$TST.lastRelatedTab = tab;
	}
	});

This looks need to be tracked as an issue instead of a discussion (Q&A).

[DreamC]

Well, I didn't know if this actually was an issue or I was doing something wrong.

But anyway, what is the difference between the "Firefox controls" and "Emulate" options? Or the only point should be that the first one allows other addons to work?

[konradmb]

Your first screenshot is about new child tabs opened from PINNED tabs. The correct setting is in the "Tree behavior" group at the very end.

This is very confusing. The correct setting should be moved to "Tabs opened from Existing Tabs", because that is exactly what it does. I've never found this other setting in "Tree behaviour".

I've uninstalled this addon the first time because of the way it messes with new tab creation and moved to Sidebery. Only now I've discovered that this behaviour actually can be changed. 🤨

[DreamC]

Yes, it was confusing for me as well why this option is in that section. Couldn't stick with Sideberry (even though it usually performs smoother) mostly because of interface - TST does great job at mimicking FF.

[konradmb]

Yes, the interface is nearly native. The right click menu shows all of the options coming from extensions, which is what I was missing in Sideberry.

[piroor]

This is tracked at #3180 and maybe fixed with recent commits.