From a574a21ad739053c750cc4d88dfe8d6012517747 Mon Sep 17 00:00:00 2001
From: Christopher Hunter <hunterch@vmware.com>
Date: Wed, 28 Jun 2023 11:13:21 -0700
Subject: [PATCH] feat: add float_always field to component specification

Co-authored-by: Steve Taylor <sttaylor@vmware.com>
Co-authored-by: Claire Tinati <ctinati@vmware.com
---
 pkg/cargo/kilnfile.go      |  9 +++++-
 pkg/cargo/kilnfile_test.go | 57 ++++++++++++++++++++++++++++++++++++--
 2 files changed, 63 insertions(+), 3 deletions(-)

diff --git a/pkg/cargo/kilnfile.go b/pkg/cargo/kilnfile.go
index 58f9495ab..7b98e78ef 100644
--- a/pkg/cargo/kilnfile.go
+++ b/pkg/cargo/kilnfile.go
@@ -36,6 +36,9 @@ func (kf *Kilnfile) ComponentSpec(name string) (ComponentSpec, error) {
 func (kf *Kilnfile) Glaze(kl KilnfileLock) error {
 	kf.Stemcell.Version = kl.Stemcell.Version
 	for index, spec := range kf.Releases {
+		if spec.FloatAlways {
+			continue
+		}
 		lock, err := kl.FindReleaseWithName(spec.Name)
 		if err != nil {
 			return fmt.Errorf("release with name %q not found in Kilnfile.lock: %w", spec.Name, err)
@@ -107,7 +110,11 @@ type ComponentSpec struct {
 	GitHubRepository string `yaml:"github_repository,omitempty"`
 
 	// DeGlazeBehavior changes how version filed changes when de-glaze is run.
-	DeGlazeBehavior DeGlazeBehavior `yaml:"glaze_behavior"`
+	DeGlazeBehavior DeGlazeBehavior `yaml:"maintenance_version_bump_policy"`
+
+	// FloatAlways when does not override version constraint.
+	// It skips locking it during Kilnfile.Glaze.
+	FloatAlways bool `yaml:"float_always,omitempty"`
 
 	// TeamSlackChannel slack channel for team that maintains this bosh release
 	TeamSlackChannel string `yaml:"slack,omitempty"`
diff --git a/pkg/cargo/kilnfile_test.go b/pkg/cargo/kilnfile_test.go
index aeddaa95a..08f92e366 100644
--- a/pkg/cargo/kilnfile_test.go
+++ b/pkg/cargo/kilnfile_test.go
@@ -75,7 +75,7 @@ func TestKilnfileLock_UpdateReleaseLockWithName(t *testing.T) {
 }
 
 func TestKilnfile_Glaze(t *testing.T) {
-	t.Run("it updates the Kilnfile", func(t *testing.T) {
+	t.Run("locks versions to the value in the lock", func(t *testing.T) {
 		kf := Kilnfile{
 			Releases: []ComponentSpec{
 				{Name: "banana"},
@@ -109,10 +109,42 @@ func TestKilnfile_Glaze(t *testing.T) {
 			},
 		}, kf)
 	})
+
+	t.Run("when float always is true", func(t *testing.T) {
+		kf := Kilnfile{
+			Releases: []ComponentSpec{
+				{Name: "orange", Version: "<3", FloatAlways: true},
+			},
+			Stemcell: Stemcell{
+				OS: "alpine",
+			},
+		}
+		kl := KilnfileLock{
+			Releases: []ComponentLock{
+				{Name: "orange", Version: "2.3.4"},
+			},
+			Stemcell: Stemcell{
+				OS:      "alpine",
+				Version: "42.0",
+			},
+		}
+
+		require.NoError(t, kf.Glaze(kl))
+
+		assert.Equal(t, Kilnfile{
+			Releases: []ComponentSpec{
+				{Name: "orange", Version: "<3", FloatAlways: true},
+			},
+			Stemcell: Stemcell{
+				OS:      "alpine",
+				Version: "42.0",
+			},
+		}, kf, "it does not alter the versio constraint")
+	})
 }
 
 func TestKilnfile_DeGlaze(t *testing.T) {
-	t.Run("it updates the Kilnfile", func(t *testing.T) {
+	t.Run("when de glazing", func(t *testing.T) {
 		kf := Kilnfile{
 			Releases: []ComponentSpec{
 				{Name: "mango", Version: "1.2.3", DeGlazeBehavior: LockMajor},
@@ -141,6 +173,27 @@ func TestKilnfile_DeGlaze(t *testing.T) {
 			},
 		}, kf)
 	})
+
+	t.Run("when float_always is true", func(t *testing.T) {
+		kf := Kilnfile{
+			Releases: []ComponentSpec{
+				{Name: "mango", Version: "1.2.3", DeGlazeBehavior: LockMajor, FloatAlways: true},
+			},
+		}
+		kl := KilnfileLock{
+			Releases: []ComponentLock{
+				{Name: "mango", Version: "1.2.3"},
+			},
+		}
+
+		require.NoError(t, kf.DeGlaze(kl))
+
+		assert.Equal(t, Kilnfile{
+			Releases: []ComponentSpec{
+				{Name: "mango", Version: "~1", DeGlazeBehavior: LockMajor, FloatAlways: true},
+			},
+		}, kf, "it should change the constraint")
+	})
 }
 
 func TestDeGlazeBehavior_TextUnmarshalMarshaller(t *testing.T) {