Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stemcell version validations stricter #305

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make stemcell version validations stricter #305

wants to merge 1 commit into from

Conversation

crhntr
Copy link
Contributor

@crhntr crhntr commented Dec 13, 2021

This set of new validations ensures:

  • stemcell version lock matches spec constraint
  • stemcell version and constraint are valid
  • each release lock with a stemcell has the the same os and version as the lock

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@crhntr crhntr changed the title Feature: validate: stricter stemcell version validations feature[validate]: stricter stemcell version validations Dec 13, 2021
@crhntr crhntr force-pushed the feature/validate/stemcell-versions branch from 3b61968 to 2611d9f Compare December 13, 2021 02:01
@crhntr crhntr force-pushed the feature/validate/stemcell-versions branch 2 times, most recently from 3a880d0 to d19a681 Compare March 7, 2022 22:59
@crhntr crhntr changed the title feature[validate]: stricter stemcell version validations feature (validate): stricter stemcell version validations Mar 7, 2022
@crhntr crhntr removed the request for review from wayneadams April 26, 2022 18:31
crhntr
crhntr commented Apr 26, 2022
View reviewed changes
Copy link
Contributor Author

@crhntr crhntr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I self-reviewed this a few months after writing it and still feel this is an okay improvement.

@crhntr crhntr added this to the Kiln 1.0 milestone Sep 23, 2022
@crhntr crhntr changed the title feature (validate): stricter stemcell version validations Make stemcell version validations stricter Sep 23, 2022
@crhntr crhntr force-pushed the feature/validate/stemcell-versions branch from d19a681 to 6f0a28c Compare October 19, 2022 02:55
@crhntr crhntr force-pushed the feature/validate/stemcell-versions branch 3 times, most recently from adf1704 to a4d113c Compare November 17, 2022 21:24
@crhntr crhntr force-pushed the feature/validate/stemcell-versions branch from a4d113c to 11dfdf3 Compare May 11, 2023 17:54
@crhntr
Copy link
Contributor Author

crhntr commented May 11, 2023 •
edited
Loading

I rebased this branch. I don't know if we even want this functionality anymore.

@crhntr crhntr removed this from the Kiln 1.0 milestone May 11, 2023
@crhntr crhntr force-pushed the feature/validate/stemcell-versions branch from 11dfdf3 to fe60608 Compare August 7, 2023 19:58
@crhntr crhntr force-pushed the feature/validate/stemcell-versions branch from fe60608 to 1c0b788 Compare February 24, 2024 00:19
@crhntr crhntr force-pushed the feature/validate/stemcell-versions branch from 1c0b788 to 9f19568 Compare February 26, 2024 23:42
@crhntr crhntr marked this pull request as draft February 27, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ram-pivot ram-pivot ram-pivot left review comments

Assignees
No one assigned
Labels
unscheduled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crhntr @cf-gitbot @ram-pivot