Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump (go-pivnet): import v7 everywhere #318

Merged
merged 2 commits into from
Aug 31, 2023
Merged

bump (go-pivnet): import v7 everywhere #318

merged 2 commits into from
Aug 31, 2023

Conversation

crhntr
Copy link
Member

@crhntr crhntr commented Apr 26, 2022

dependabot is not bumping major versions so I am doing it manually

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@crhntr
Copy link
Member Author

crhntr commented Aug 7, 2023

I just rebased the PR on main.

This was referenced Aug 17, 2023
Closed
Merged
@pabloarodas
Copy link
Contributor

@crhntr could you please add some context about all the fake created in this PR, I don't see any relation to the v7 import and they are not being used either.

@crhntr
Copy link
Member Author

crhntr commented Aug 31, 2023 •
edited
Loading

Those were probably part of old code that has since been removed. This PR is really old. I'll clean it up.

@crhntr
bump (go-pivnet): import v7 everywhere
f7865fc 
dependabot is not bumping major versions so I am doing it manually
@crhntr
fix: move notes fakes to internal package
8dd34e3 
there was a problem with the generate statements
@crhntr
Copy link
Member Author

crhntr commented Aug 31, 2023

Those were probably part of old code that has since been removed. This PR is really old. I'll clean it up.

Looks like the generate statements were a bit off. I fixed them and ran generate again. This should be good now. I guess the find and replace for interface{} -> any was a bit aggressive. I should not have changed the contents of generated files.

pabloarodas
pabloarodas approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@pabloarodas pabloarodas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@pabloarodas pabloarodas merged commit 12902dc into main Aug 31, 2023
3 checks passed
@pabloarodas pabloarodas deleted the bump/go-pivnet-to-v7 branch August 31, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloarodas pabloarodas pabloarodas approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crhntr @cf-gitbot @pabloarodas