Make where we work with BOSH Release tarballs explicit #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
component.Spec
andcargo.ComponentSpec
->cargo.BOSHReleaseTarballSpecification
component.Lock
andcargo.ComponentLock
->cargo.BOSHReleaseTarballLock
cargo.ReleaseSourceTypeBOSHIO
->cargo.BOSHReleaseTarballSourceTypeBOSHIO
cargo.ReleaseSourceTypeS3
->cargo.BOSHReleaseTarballSourceTypeS3
cargo.ReleaseSourceTypeGithub
->cargo.BOSHReleaseTarballSourceTypeGithub
cargo.ReleaseSourceTypeArtifactory
->cargo.BOSHReleaseTarballSourceTypeArtifactory
Discussion
This refactor is intended to make it easier to think about and code around the BOSH releases tarballs we package.
component.Lock
andcargo.ComponentLock
. They have literally been the same thing for a while; this commit removes the indirection.component.Local
andcomponent.Exported
no longer embed thecargo.ComponentLock
but have it as a non-embedded field. This makes refactors easier and makes it clear that those types should not inherit methods from the Lock. For the most part, this change is reversible in a non-breaking way.