-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BOSH Release tarball reading utilities #410
Conversation
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the refactor to the release
package, found it confusing when using github.com/kiln/pkg/tile
package in other projects.
3a597de
to
ac9600c
Compare
I agree renaming it would make it make more sense. I also don't like that I take the "tile" identifier; it is such a good variable name. Maybe tilerelease? Unfortunately, "release" is such an overloaded term. |
Why add this to |
We do use these utilities in kiln bake. I have found these utilities to be useful in buildpacks and so I wanted to put these utilities somewhere open source. They used to be in PPET but I have found using that even for internal projects not easy. GOPRIVATE is not fun to set up in CI. After thinking about your comment. I think these functions make more sense in cargo because they operate on the BOSH Release Tarballs within the tiles. Also it might make sense to add the bosh release package data to the Kilnfile.lock. |
9fa2b1d
to
d1ea71a
Compare
- refator: add test coverage for TestReadBOSHReleaseManifestsFromTarballs - feat: add Stemcell method on BOSHReleaseManifest - fix linter errors - refactor: use new stemcell utility
b2b8b89
to
3fa56ea
Compare
this reduces number of templating functions in the kilnfile. interpolation in the Kilnfile is a mistake and should be factored out this is to remove circular dependency when we move bosh release tarball functions to cargo
this is easier to read
e11a673
to
dbe7c82
Compare
type any = interface{}
dbe7c82
to
1d1254b
Compare
This adds some utilities for reading BOSH release manifests (release.MF) from tarballs.
I refactor the builder and acceptance tests to use this to show that this makes sense as a place for these utility functions. My main intent for adding them was to use them in the kiln buildpacks.