feat: allow TanzuNet slug to be set in the Kilnfile stemcell criteria #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
@jaristiz I vaguely remember talking with you about this change a long time ago. |
crhntr
force-pushed
the
feat-set-stemcell-slug-in-kilnfile
branch
from
baa37f6
to
ea194d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while we have maintained a switch statement that mapped stemcell slugs like "ubuntu-jammy/1.2" to product slugs like "stemcells-ubuntu-jammy". This was annoying but not that big of an issue because it we do it every year or so. Instead of continuing this pattern, lets add a field to the Kilnfile so the CLI does not need to change when a new stemcell is released.
This change helps me with my buildpack work because, I want to be able to compile releases against stemcells and I want the particular stemcell to be specified in the tile source. I don't want to maintain the same switch statement in both Kiln and in the buildpack. I intend to import these functions into the buildpack.