kiln bake always adds tile source revision and kiln version to kiln_metadata in product template

[crhntr]

this change ensures tile metadata always has kiln_metadata and the contents include the repository hash and the kiln CLI version.

All tile metadata files will now include a section like this:

  kiln_metadata:
+   metadata_git_sha: 5d2741ad92192521b7282a838f3ba24835cd3af2
+   kiln_version: "0.86.0"
  releases:
    - name: banana
      version: "1.2.3"
      sha1: "the sha 1 sum of the tarball file"
+     commit_sha: "the commit sha from release.MF"

The field name "metadata_git_sha" is a bit awkward but it is how releng (tas, ist, and tasw) have been doing it for years.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

[notrepo05]

Metadata appears correctly testing against hello-tile.

[rizwanreza]

• Change error message
• Please test and make sure OpsManager is okay with this field.
• Add context around where the prefactors are coming from
• PR title and description can be clearer around what is impacted (kiln bake etc.)

[crhntr]

I was not able to test this on toolsmiths today. @notrepo05 if you don't get a chance to do it, I would be happy to do that test next week.

[pabloarodas]

@crhntr @notrepo05 where you able to test the changes? let us know if everything went well so we can proceed and merge this PR.

[notrepo05]

This passed an upgrade from a standard 4.0.7 sf-tas to a slightly changed "4.0.8-build.1" sf-tas built with this branch of Kiln on Toolsmith.

For reference, here's the added tile metadata:

kiln_metadata:
  metadata_git_sha: 8c2bfbbdcf77f5f4c3902012b368ae6d825d8a59
  kiln_version: unknown

[notrepo05]

Hi @rizwanreza , I believe this is ready to be merged.

• Change error message ✅
  • f494908
• Please test and make sure OpsManager is okay with this field. ✅
• Add context around where the prefactors are coming from ✅
  • These refactors are actually necessary for the functionality to add commit_sha to the releases section. This was miscommunicated.
• PR title and description can be clearer around what is impacted (kiln bake etc.) ✅

[rizwanreza]

@pabloarodas Approved the changes.

[pabloarodas]

@notrepo05 when will you need a kiln release including these changes?

[notrepo05]

@pabloarodas I think the sooner the better- essentially we're overdue. @crhntr might have a specific date in mind though

[pabloarodas]

@pabloarodas I think the sooner the better- essentially we're overdue. @crhntr might have a specific date in mind though

Ok, I'm trying to get merged several of the open PRs so we can have a single release including all the features