add S3 aws role arn #416
Merged
add S3 aws role arn #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an optional "aws_role_arn" property for a release source that can assume a role in an aws account. [#185364456](https://www.pivotaltracker.com/story/show/185364456) Co-authored-by: Andrew Garner <garnera@vmware.com> Co-authored-by: Kyle Ong <kyleo@vmware.com>
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
we don't specify the iaas implementation in other config keys so we decided to remove the prefix here too we also changed the control flow in NewS3ReleaseSourceFromConfig to miror the implementation in leftovers more closely: https://github.com/pivotal/leftovers/commit/34fcf991bb381011f8ead1acb9beba866da94025 Co-authored-by: Ramkumar Vengadakrishnan <ramkumarv@vmware.com>
ram-pivot
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR based on #401 to do some refactors before merging the changes @abg made.