Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make find-release-version output match Kilnfile.lock #422

Closed
wants to merge 1 commit into from

Conversation

nouseforaname
Copy link

We from cryo just started using kiln for our tile builds. We have quite a few tiles and mostly want to bump versions in a tile to latest since we don't ship many releases in a tile.
I found the output of the find-release-version command somewhat confusing because it doesn't really match the structure of the Kilnfile.lock so I figured I'd try to PR this in.

What does this do? It drops the releaseVersionOutput that wasn't used anywhere else and just uses BOSHReleaseTarballLock to generate the output.

It adds the option to output yaml (in case you want to use the output and put it into the lockfile..)

it also updates the BOSHReleaseTarballLock with json tags so marshalling produces the expected output.

We from cryo just started using kiln for our tile builds. We have quite
a few tiles and mostly want to bump versions in a tile to latest since
we don't ship many releases in a tile.
I found the output of the find-release-version command somewhat
confusing because it doesn't really match the structure of the
Kilnfile.lock so I figured I'd try to PR this in.

What does this do? It drops the `releaseVersionOutput` that wasn't used
anywhere else and just uses `BOSHReleaseTarballLock` to generate the
output.

It adds the option to output yaml (in case you want to use the output
and put it into the lockfile..)

it also updates the `BOSHReleaseTarballLock` with json tags so
marshalling produces the expected output.
@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@pabloarodas
Copy link
Contributor

@nouseforaname I opened a new PR to run our test CI since it doesn't run on forks. I also fixed JSON output and added tests for it. Closing this PR on behalf of the new one.

@nouseforaname
Copy link
Author

Thanks!

@pabloarodas
Copy link
Contributor

@nouseforaname Sorry about this but after checking with the team, we found that the current output of the kiln find-release-version cannot be changed since it is being used by other tools in our TAS CI. Having an additional yaml output but with different fields wouldn't affect those tools but would make the command not have a consistent output for the two formats which is not desirable for us.

We would like to understand your use-case for the yaml output so we can find an alternative to what you need to do. Could you please explain why would you need the kiln find-release-version to match the Kilnfile.lock format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants