add a utility function to the tile package for reading metadata from a remote tile file #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta in product template
this refactor is in reponse to the Slack comment "this resilient enough to lots of things that might go wrong?" reffering to the previous GitMetadataSHA implementation I agree it was not simple. I hope this is better.
this was required to make the builder.ReleaseManifestReader.Read method not require an billy.FS
also allows upload of compiled releases
this reduces the responsibility of the builder package it is no longer used in the local release source both rely on the tarball loading from the cargo package
…p.Request this is so the server can be something other than TanzuNet, maybe artifactory?
…oductFile this new name better aligns with the generality of this utility
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
I accidentally used the wrong base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be helpful for making kiln test tile revisions against recently released tiles.
I intend to use this on a few upcoming features but am adding it now because this function is a helpful utility that TAS Operability may get value from.
I intentionally did not use the pivnet package because we use various versions of that module in this package. Once #318 is merged, we may want to re-evaluate this API. As it is, this implementation might work with Artifactory.