add function to tile package for reading metadata from a tanzunet product file #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be helpful for making kiln test tile revisions against recently released tiles.
I intend to use this on a few upcoming features but am adding it now because this function is a helpful utility that TAS Operability may get value from.
I intentionally did not use the pivnet package because we use various versions of that module in this package. Once #318 is merged, we may want to re-evaluate this API. As it is, this implementation might work with Artifactory. I expect a future utility function to call this and pass in the appropriate information from a
pivnet.ProductFile
(ppet has an example of how to do this if the test comment is not enough).This test change also switches from "gomega" to "testify/assert" for the tile package. We have talked about whether or not to do this for the whole project. For now, I think we should converge to one set of tools per package. Each package may have different needs served better by Gomega/Ginkgo, godog, standard library alone, or standard library + testify.
Example