feat: make find-release-version output match Kilnfile.lock #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We from cryo just started using kiln for our tile builds. We have quite a few tiles and mostly want to bump versions in a tile to latest since we don't ship many releases in a tile. I found the output of the find-release-version command somewhat confusing because it doesn't really match the structure of the Kilnfile.lock so I figured I'd try to PR this in. What does this do? It drops the `releaseVersionOutput` that wasn't used anywhere else and just uses `BOSHReleaseTarballLock` to generate the output. It adds the option to output yaml (in case you want to use the output and put it into the lockfile..) it also updates the `BOSHReleaseTarballLock` with json tags so marshalling produces the expected output. Authored-by: Konstantin Kiess <kkiess@vmware.com>
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
- Json output now also matches kilnfile lock format - Added tests for yaml output and fixed tests for new json output format - Removed releaseVersionOutput type since it was not used anymore Authored-by: Pablo Rodas <prodas@vmware.com>
pabloarodas
force-pushed
the
feat/frv-output-match-lock-format
branch
from
b67b677
to
8267fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We from cryo just started using kiln for our tile builds. We have quite a few tiles and mostly want to bump versions in a tile to latest since we don't ship many releases in a tile.
I found the output of the find-release-version command somewhat confusing because it doesn't really match the structure of the Kilnfile.lock so I figured I'd try to PR this in.
What does this do? It drops the
releaseVersionOutputthat wasn't used anywhere else and just usesBOSHReleaseTarballLockto generate the output.It adds the option to output yaml (in case you want to use the output and put it into the lockfile..)
it also updates the
BOSHReleaseTarballLockwith json tags so marshalling produces the expected output.Authored-by: Konstantin Kiess kkiess@vmware.com