Fixes bug when reading tile_name variable #482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team recently experienced CI failures when trying to bake a tile, after passing in the tas variables file
That file has the properties:
tile_name: SRT
The result was a strange error: 'tile_name value must be a string got value "SRT" with type string'
After investigating more, we found this commit included a small typo in how the 'ok' value is handled
Worth noting - it was very hard to test this via the existing Bake tests. Because of this, we needed to export the function to be able to test it properly, but we know this is probably not ideal.
Our hope is you can help to review this and find a better way to test via the existing fixturing, or be able to confirm that making it public is acceptable