Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use basic auth for all request to artifactory if credentials are defined #491

Merged
merged 1 commit into from
May 14, 2024

Conversation

dlinsley
Copy link
Contributor

Resolves #474

verified local tests covers change.

Tested following subcommands against an artifactory that required authentication:

  • find-release-version
  • update-stemcell
  • update-release

Signed-off-by: Daniel Linsley <dlinsley@vmware.com>
@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Copy link
Contributor

@crhntr crhntr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dlinsley
Copy link
Contributor Author

Also confirmed this is functional for :

  • bake with & without --final
  • re-bake

With an artifactory requiring authentication

@dlinsley dlinsley requested a review from pabloarodas May 6, 2024 16:46
@pabloarodas pabloarodas merged commit beaa050 into main May 14, 2024
4 of 5 checks passed
@pabloarodas pabloarodas deleted the artifactory_auth branch May 14, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifactory release source assumes the artifactory has anonymous access enabled
4 participants