add option to use local test image tarball instead of building the image #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some teams would like to use `kiln test` from concourse. That concourse could be shared, like runway // tpe concourse instances. These, even using authentication, are getting rate limited against dockerhub. Effectively to run kiln test, we'd first need to preload the images required to build the test image ( every FROM arg used in the Dockerfile) avoid the pull ibeing executed implicitly when docker build is run by `kiln test` To avoid having to actually build an image ( which would either require to preload the images for the Dockerfile or being able to pull from dockerhub) we could use this flag to run `docker load -i $IMAGE_PATH` instead of building. this way, the test image can be `acquired` via docker proxy registries..
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
nouseforaname
force-pushed
the
main
branch
2 times, most recently
from
12753b5
to
e7461cc
Compare
why?: because some CI systems cannot get past the dockerhub rate limitation. We want to use kiln test for the csb tiles. But we use the tpe / runway concourse. These instances make it impossible to communicate with dockerhub because of rate limits ( even with authenticated pulls ) We can make the `kiln test` execution work by pre loading the images that are used as FROM stages in `internal/test/Dockerfile` into the docker host we start in the concourse task. Essentially we end up pulling the images from an accessible repository, then we retag them to match the expected FROM args and that makes the implicit image build work. Instead it would be nice to avoid having to run the build stage and make kiln test consume a provided image instead so it can be run offline.
crhntr
requested changes
Jun 6, 2024
There was a problem hiding this comment.
@notrepo05 if the tests run well on your machine, I'm happy to approve these changes once the small changes I suggested are either incorporated or rejected by @nouseforaname.
- replace `"` with `\`` quoted strings - use closer helper function and move defer up
|
@crhntr I added a commit with the requested changes. |
|
I haven't had the bandwidth to debug the pipeline, but the integration and unit tests for It appears the tests are failing due to CI misconfiguration: Run actions/checkout@v4
with:
fetch-depth: 0
repository: pivotal-cf/kiln
ssh-strict: true
ssh-user: git
persist-credentials: true
clean: true
sparse-checkout-cone-mode: true
fetch-tags: false
show-progress: true
lfs: false
submodules: false
set-safe-directory: true
Error: Input required and not supplied: token |
|
recreated in #495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short, we'd like to run
kiln testin a shared concourse.We are prevented from doing so because we cannot pull the images that https://github.com/pivotal-cf/kiln/blob/main/internal/test/Dockerfile requires for the FROM steps.
We are using authenticated pulls but we still get rate limited.
We'd like to be able to prebuild the required image via the
build-ocitask and then be able to consume the prebuild image in outkiln testtask