Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to use local test image tarball instead of building the image #494

Closed
wants to merge 3 commits into from

Commits on Jun 5, 2024

  1. add flag to provide docker test image as tarball

    some teams would like to use `kiln test` from concourse. That concourse
    could be shared, like runway // tpe concourse instances. These, even
    using authentication, are getting rate limited against dockerhub.
    
    Effectively to run kiln test, we'd first need to preload the images
    required to build the test image ( every FROM arg used in the Dockerfile)
    avoid the pull ibeing executed implicitly when docker build is run by `kiln test`
    
    To avoid having to actually build an image ( which would either require
    to preload the images for the Dockerfile or being able to pull from dockerhub)
    we could use this flag to run `docker load -i $IMAGE_PATH` instead of building.
    
    this way, the test image can be `acquired` via docker proxy registries..
    nouseforaname committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    757c9ec View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. add alternative to execute image-build every time

    why?:
    
    because some CI systems cannot get past the dockerhub rate limitation.
    We want to use kiln test for the csb tiles. But we use the tpe / runway
    concourse. These instances make it impossible to communicate with dockerhub
    because of rate limits ( even with authenticated pulls )
    
    We can make the `kiln test` execution work by pre loading the images that
    are used as FROM stages in `internal/test/Dockerfile` into the docker host
    we start in the concourse task. Essentially we end up pulling the images from
    an accessible repository, then we retag them to match the expected FROM args
    and that makes the implicit image build work.
    
    Instead it would be nice to avoid having to run the build stage and make kiln
    test consume a provided image instead so it can be run offline.
    nouseforaname committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0963425 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. implement changes requested on review

    - replace `"` with `\`` quoted strings
    - use closer helper function and move defer up
    nouseforaname committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    2c5ae08 View commit details
    Browse the repository at this point in the history