From 219ca5043c2b8767641bb187f6734f6b0af33f0b Mon Sep 17 00:00:00 2001 From: Amine Benseddik Date: Wed, 10 Nov 2021 15:02:36 +0100 Subject: [PATCH] fix(gosec): don't defer file Close() --- internal/wrapper/git.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/internal/wrapper/git.go b/internal/wrapper/git.go index 9ad4a50..ce86863 100644 --- a/internal/wrapper/git.go +++ b/internal/wrapper/git.go @@ -93,9 +93,10 @@ func isEmptyDirOrNotExist(name string) (found bool, err error) { } return false, err } - defer func() { - err = f.Close() - }() + + if err = f.Close(); err != nil { + return true, err + } _, err = f.Readdirnames(1) // Or f.Readdir(1) if err == io.EOF {