-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please fix the Redis store_many_vectors_case #75
Comments
I have fixed this according to your suggestion in #76. Can you check it again? |
@xieqihui Thanks! Could you do me one more favor and add tests for the new method store_many_vectors ? Sorry for not mentioning this before, but now that more people are working on NearPy we should take care of the tests for real. |
I’m working on the tests.
Best regards,
Qihui
From: Ole <notifications@github.com>
Reply-To: pixelogik/NearPy <reply@reply.github.com>
Date: Wednesday, 7 February 2018 at 10:42 PM
To: pixelogik/NearPy <NearPy@noreply.github.com>
Cc: Qihui Xie <qihui@propertyguru.com.sg>, Mention <mention@noreply.github.com>
Subject: Re: [pixelogik/NearPy] Please fix the Redis store_many_vectors_case (#75)
@xieqihui<https://github.com/xieqihui> Thanks! Could you do me one more favor and add tests for the new method store_many_vectors? Sorry for not mentioning this before, but now that more people are working on NearPy we should take care of the tests for real.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#75 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AUGNID_Y6rvxCDWZOkxaZtW0igNct0BPks5tSbZVgaJpZM4R7J9->.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@xieqihui Sorry for the hassle.
Could you please create a new pull request for your store_many_vectors addition and make this little adjustment I suggested, so that store_many_vectors works even if not Redis is used for storage?
The text was updated successfully, but these errors were encountered: