Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix the Redis store_many_vectors_case #75

Open
pixelogik opened this issue Feb 6, 2018 · 3 comments
Open

Please fix the Redis store_many_vectors_case #75

pixelogik opened this issue Feb 6, 2018 · 3 comments

Comments

@pixelogik
Copy link
Owner

@xieqihui Sorry for the hassle.

Could you please create a new pull request for your store_many_vectors addition and make this little adjustment I suggested, so that store_many_vectors works even if not Redis is used for storage?

@xieqihui
Copy link
Contributor

xieqihui commented Feb 7, 2018

I have fixed this according to your suggestion in #76. Can you check it again?

@pixelogik
Copy link
Owner Author

pixelogik commented Feb 7, 2018

@xieqihui Thanks! Could you do me one more favor and add tests for the new method store_many_vectors ? Sorry for not mentioning this before, but now that more people are working on NearPy we should take care of the tests for real.

@xieqihui
Copy link
Contributor

xieqihui commented Feb 13, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants