Skip to content

Commit

Permalink
Fix docstring update in Vizier build
Browse files Browse the repository at this point in the history
Summary: D11196 removed the shellscript that we were originally using to generate the docs. this led to this part in the building failing, since the target no longer existed.

Test Plan: Created an rc, verified the build passes and docs are updated

Reviewers: philkuz, vihang, zasgar

Reviewed By: vihang

Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11752

GitOrigin-RevId: 3cc2661
  • Loading branch information
aimichelle authored and copybaranaut committed Jul 5, 2022
1 parent c66219a commit 1319626
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ K8S_TESTING_CLUSTER = 'https://cloud-testing.internal.corp.pixielabs.ai'
K8S_TESTING_CREDS = 'pixie-prod-testing-cluster'

// PXL Docs variables.
PXL_DOCS_BINARY = '//src/carnot/docstring:docstring_integration'
PXL_DOCS_BINARY = '//src/carnot/docstring:docstring'
PXL_DOCS_FILE = 'pxl-docs.json'
PXL_DOCS_BUCKET = 'pl-docs'
PXL_DOCS_GCS_PATH = "gs://${PXL_DOCS_BUCKET}/${PXL_DOCS_FILE}"
Expand Down Expand Up @@ -1236,7 +1236,7 @@ def updatePxlDocs() {
WithSourceCodeK8s {
container('pxbuild') {
def pxlDocsOut = "/tmp/${PXL_DOCS_FILE}"
sh "bazel run ${PXL_DOCS_BINARY} ${pxlDocsOut}"
sh "bazel run ${PXL_DOCS_BINARY} -- --output_json ${pxlDocsOut}"
sh "gsutil cp ${pxlDocsOut} ${PXL_DOCS_GCS_PATH}"
}
}
Expand Down

0 comments on commit 1319626

Please sign in to comment.