Remove one off container push targets (#1517)

Summary: We build and push most of our distributed images using container bundles. We use skaffold to test local dev builds. So these one off push targets are unused and increase maintenance burden. Instead just remove them. Type of change: /kind cleanup Test Plan: All existing builds and deploys work. Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
pixie-io · Jun 16, 2023 · c600265 · c600265
1 parent c562b23
commit c600265
Show file tree

Hide file tree

Showing 23 changed files with 1 addition and 248 deletions.
diff --git a/src/cloud/api/BUILD.bazel b/src/cloud/api/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -61,12 +60,3 @@ pl_go_image(
         "//src/cloud:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_api_server_image",
-    format = "Docker",
-    image = ":api_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/api_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/cloud/artifact_tracker/BUILD.bazel b/src/cloud/artifact_tracker/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -58,12 +57,3 @@ pl_go_image(
         "//src/cloud:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_artifact_tracker_server_image",
-    format = "Docker",
-    image = ":artifact_tracker_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/artifact_tracker_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/cloud/auth/BUILD.bazel b/src/cloud/auth/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -58,12 +57,3 @@ pl_go_image(
         "//src/cloud:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_auth_server_image",
-    format = "Docker",
-    image = ":auth_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/auth_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/cloud/config_manager/BUILD.bazel b/src/cloud/config_manager/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -35,15 +34,6 @@ pl_go_image(
     ],
 )
 
-container_push(
-    name = "push_config_manager_server_image",
-    format = "Docker",
-    image = ":config_manager_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/config_manager_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
-
 go_library(
     name = "config_manager_lib",
     srcs = ["config_manager_server.go"],

diff --git a/src/cloud/cron_script/BUILD.bazel b/src/cloud/cron_script/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -35,15 +34,6 @@ pl_go_image(
     ],
 )
 
-container_push(
-    name = "push_cron_script_server_image",
-    format = "Docker",
-    image = ":cron_script_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/cron_script_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
-
 go_library(
     name = "cron_script_lib",
     srcs = ["cron_script_server.go"],

diff --git a/src/cloud/indexer/BUILD.bazel b/src/cloud/indexer/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -59,12 +58,3 @@ pl_go_image(
         "//src/cloud:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_indexer_server_image",
-    format = "Docker",
-    image = ":indexer_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/indexer_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/cloud/metrics/BUILD.bazel b/src/cloud/metrics/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -35,15 +34,6 @@ pl_go_image(
     ],
 )
 
-container_push(
-    name = "push_metrics_server_image",
-    format = "Docker",
-    image = ":metrics_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/metrics_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
-
 go_library(
     name = "metrics_lib",
     srcs = ["metrics_server.go"],

diff --git a/src/cloud/plugin/BUILD.bazel b/src/cloud/plugin/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -35,15 +34,6 @@ pl_go_image(
     ],
 )
 
-container_push(
-    name = "push_plugin_server_image",
-    format = "Docker",
-    image = ":plugin_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/plugin_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
-
 go_library(
     name = "plugin_lib",
     srcs = ["plugin_server.go"],

diff --git a/src/cloud/plugin/load_db/BUILD.bazel b/src/cloud/plugin/load_db/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_docker//container:image.bzl", "container_image")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image", "pl_go_test")
@@ -69,15 +68,6 @@ pl_go_image(
     ],
 )
 
-container_push(
-    name = "push_plugin_db_updater_image",
-    format = "Docker",
-    image = ":plugin_db_updater_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/plugin/load_db",
-    tag = "{STABLE_BUILD_TAG}",
-)
-
 pl_go_test(
     name = "load_db_test",
     srcs = ["load_db_test.go"],

diff --git a/src/cloud/profile/BUILD.bazel b/src/cloud/profile/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -56,12 +55,3 @@ pl_go_image(
         "//src/cloud:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_profile_server_image",
-    format = "Docker",
-    image = ":profile_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/profile_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/cloud/project_manager/BUILD.bazel b/src/cloud/project_manager/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -56,12 +55,3 @@ pl_go_image(
         "//src/cloud:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_project_manager_server_image",
-    format = "Docker",
-    image = ":project_manager_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/project_manager_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/cloud/scriptmgr/BUILD.bazel b/src/cloud/scriptmgr/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -54,12 +53,3 @@ pl_go_image(
         "//src/cloud:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_scriptmgr_server_image",
-    format = "Docker",
-    image = ":scriptmgr_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/scriptmgr_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/cloud/vzconn/BUILD.bazel b/src/cloud/vzconn/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -58,12 +57,3 @@ pl_go_image(
         "//src/cloud:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_vzconn_server_image",
-    format = "Docker",
-    image = ":vzconn_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/vzconn_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/cloud/vzmgr/BUILD.bazel b/src/cloud/vzmgr/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -65,12 +64,3 @@ pl_go_image(
         "//src/cloud:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_vzmgr_server_image",
-    format = "Docker",
-    image = ":vzmgr_server_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/cloud/vzmgr_server_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/operator/BUILD.bazel b/src/operator/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -49,12 +48,3 @@ pl_go_image(
         "//k8s:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_operator_image",
-    format = "Docker",
-    image = ":operator_image",
-    registry = "gcr.io",
-    repository = "pl-dev-infra/vizier/operator_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/utils/cert_provisioner/BUILD.bazel b/src/utils/cert_provisioner/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -51,12 +50,3 @@ pl_go_image(
         "//src:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_cert_provisioner_image",
-    format = "Docker",
-    image = ":cert_provisioner_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/vizier/cert_provisioner_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/utils/pixie_deleter/BUILD.bazel b/src/utils/pixie_deleter/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -47,12 +46,3 @@ pl_go_image(
         "//src:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_vizier_deleter_image",
-    format = "Docker",
-    image = ":vizier_deleter_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/vizier/vizier_delete_image",
-    tag = "{STABLE_BUILD_TAG}",
-)
diff --git a/src/utils/pixie_updater/BUILD.bazel b/src/utils/pixie_updater/BUILD.bazel
@@ -14,7 +14,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("//bazel:pl_build_system.bzl", "pl_go_binary", "pl_go_image")
 
@@ -52,12 +51,3 @@ pl_go_image(
         "//src:__subpackages__",
     ],
 )
-
-container_push(
-    name = "push_vizier_updater_image",
-    format = "Docker",
-    image = ":vizier_updater_image",
-    registry = "gcr.io",
-    repository = "pixie-oss/pixie-dev/vizier/vizier_update_image",
-    tag = "{STABLE_BUILD_TAG}",
-)