chore: Upgrade go-git #1935
Open
chore: Upgrade go-git #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vihang Mehta <vihang@px.dev>
ddelnano
reviewed
May 30, 2024
| + cgo = True, | ||
| importpath = "github.com/cloudflare/circl/math/fp448", | ||
| visibility = ["//visibility:public"], | ||
| deps = [ |
There was a problem hiding this comment.
What's the purpose of this patch? Does this work around the fact that our go toolchain is old?
There was a problem hiding this comment.
Not really, newer bazel tooling will make the patching easier, but the main issue is that circl has a odd cgo setup that gazelle doesn't handle automatic build file generation for. So we have to patch what gazelle generates.
See bazel-contrib/bazel-gazelle#1543 and google/go-github#2932 for other folks who ran into this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is to address a CVE.
Relevant Issues: CVE-2023-49569
Type of change: /kind cve
Test Plan: Ran the versions gen script, ensured it still works.