-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support nix package #455
Comments
If you'd like to build if for youself, make sure you've installed the nix package manager, and then:
|
Thanks for doing this! Can you create a pull request for the ffi tmpfile patch? The load path issue is more complicated... I don't really like having to hard code these paths, I posted some thoughts on this in #429. |
I agree, the load-path issue is a bit tricky. From a distro-packager's point of view, pixie's binary/c path currently consists of a combination of:
What I think should happen:
This would be sufficient to cleanly package pixie in distros. Additionally, we might think about:
|
Quick update: You can try it on your distribution by installing the nix package manager as per http://nixos.org/nix/ |
Sorry for off topic, but just for reference and convenience for future readers, the pixie executable via the above installation is named |
@vyp thanks for trying out the package. Should we rename |
I can only say I'd call the package |
I feel, that it's a bit unconvential for linux packages to add the Regarding the executable name, I think I'll just mirror the mainline build script, so, if somebody would update the Makefile + Examples to call Anybody else we should ask for blessing the package layout? Timothy did come up with much of the impl. Do you have any strong feelings on this @halgari? |
I've added a commit with Btw, I'm still in favor of |
Btw2, I'm sorry if my packaging job came off as trying to force a convention upstream. |
@bendlas No, first of all, thank you for packaging it and spending all the time making the nix expression and this detailed ticket! Original intent of my comment was to just do some extra documentation so future readers/users wouldn't give up or think something went wrong, and/or to save time because it took me a few minutes to find the But if you want my input on naming (for whatever it's worth), I'd have to vote against For binary name I'd also just go with But |
(I'd also prefer to have the package called just |
I'd vote for |
- Pixie supports macOS. Nix package should too. - Updated executable name as discussed in pixie-lang/pixie/issues/455.
- Pixie supports macOS. Nix package should too. - Updated executable name as discussed in pixie-lang/pixie/issues/455. closes #33771
After seeing a couple of years without picking up significant usage, pixie is on track to be removed again from NixOS. I believe there is still substantial value for the pixie project to be had from maintaining a Nix build descriptor. Luckily that needs not exist within the main distribution. Either pixie could pick it up for doing CI and other builds, or otherwise I may move it to Nix User Repository |
I've packaged pixie with nix: https://github.com/bendlas/nixpkgs/tree/a15e55bdbe956273f0be3915f8c325a958080fb2/pkgs/development/interpreters/pixie (the .patch file, in particular)
I think that nixos can offer tremendous value to pixie:
In order to get pixie built, I had to do some work, that I'd like to offer back upstream. This will also benefit other distributions, that would like to package pixie:
config.edn
/tmp/tmp.cpp
and compiles it. This is not concurrency-safe, as well as a security hole + it doesn't work when /tmp is not writable (as is the case within a nix-build). My patch replaces this with a usage of (getenv "TMPDIR") + mkdtemp to create a temporary directory to compile its ffi info in.It should be clear, that all of this are issues, not just concerning nixos, but any distribution, really.
However, I didn't create a pull request right away, because I'd like to get feedback from pixie's maintainers, before reworking its build process. If you are interested and also willing to keep half an eye on integration, I'd be willing push some patches to you, as well as get pixie into the nixos distribution.
The text was updated successfully, but these errors were encountered: