Feature presidecms 2565 fk field with same name as object leads to errors filtering #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-as-object-leads-to-errors-filtering'.
- if column does not exists in resolved object then try arguments.columnDefinition - if column exists in both resolved object and source object then throw error
DominicWatson
requested changes
Jan 9, 2024
| if ( !structKeyExists( cols, ListLast( key, ". ") ) ) { | ||
| cols = arguments.columnDefinitions; | ||
| } else { | ||
| if ( objName!=arguments.objectName && structKeyExists( arguments.columnDefinitions, ListLast( key, "." ) ) ) { |
There was a problem hiding this comment.
This doesn't feel right. We should be able to work with both and I think the answer is that the query param names would need to be made unique is all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.