Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRESIDECMS-2480 Apply access check prior to header setting #1466

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

PRESIDECMS-2480 Apply access check prior to header setting #1466

wants to merge 2 commits into from

Conversation

vivienwong
Copy link
Contributor

No description provided.

@zspitzer
Copy link
Contributor

@vivienwong should the access check happen before the etag short circuit?

@DominicWatson
Copy link
Contributor

Thanks for this @vivienwong

Yes, probably @zspitzer - have added some further refactoring also to allow the interception point to do more useful things (i.e. also do https://presidecms.atlassian.net/browse/PRESIDECMS-2841 in the same work here as closely related). I've also moved the etag checkpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivienwong @zspitzer @DominicWatson