PRESIDECMS-2944 outputView & outputViewlet #1536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her-perf-tweaks'.
…Viewlet These can be used by product and app developers to streamline including of views and viewlets in such a way that they are directly buffered to output rather than being saved multiple times when renderView() calls are nested multiple layers deep. commit 77f1b72 Author: Dominic Watson <watson.dominic@gmail.com> Date: Thu Sep 26 15:08:32 2024 +0100 [twgit] Init feature 'feature-PRESIDECMS-2944_buffered-output-functions'.
| deferredViewlet = requestContext.getDeferredViewlet(); | ||
| viewletArgs = requestContext.getViewletArgs( viewletArgs ); | ||
| } | ||
| requestContext.popViewletContext(); |
There was a problem hiding this comment.
Can we move this higher up and return early? (ie before if ( IsNull( local.result ) )
if ( !IsNull( local.result ) ) {
There was a problem hiding this comment.
No, because requestContext.getViewletView(), etc. all depend on the viewlet context being the current viewlet. Can/must pop it after that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more options for developers with regards rendering views and viewlets. See https://community.preside.org/t/an-interesting-performance-problem-and-proposed-new-helpers-to-alleviate/178/2